Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for Linux networking V3 #16

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Conversation

nupuruttarwar
Copy link
Collaborator

No description provided.

@nupuruttarwar
Copy link
Collaborator Author

This PR is not ready for review

@nupuruttarwar nupuruttarwar force-pushed the update_lnw_v3 branch 7 times, most recently from 72e4d0f to 95491c9 Compare April 4, 2024 20:34
@nupuruttarwar nupuruttarwar marked this pull request as ready for review April 4, 2024 20:54
docs/apps/lnw/es2k/es2k-linux-networking.md Outdated Show resolved Hide resolved
docs/apps/lnw/es2k/es2k-linux-networking.md Outdated Show resolved Hide resolved
docs/apps/lnw/es2k/es2k-linux-networking.md Show resolved Hide resolved
docs/apps/lnw/es2k/es2k-lnw-overlay-vms.md Outdated Show resolved Hide resolved
docs/apps/lnw/es2k/es2k-lnw-overlay-vms.md Outdated Show resolved Hide resolved
docs/apps/lnw/es2k/es2k-lnw-overlay-vms.md Outdated Show resolved Hide resolved
docs/apps/lnw/es2k/es2k-lnw-overlay-vms.md Show resolved Hide resolved
docs/apps/lnw/es2k/es2k-lnw-overlay-vms.md Show resolved Hide resolved
Signed-off-by: nupuruttarwar <[email protected]>
Copy link
Collaborator

@ffoulkes ffoulkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved without reading.

I don't mind reviewing short passages, but code reviews are a terrible way to proofread documents. Telling someone "here, go make the following forty or fifty changes" is going to hurt the author's feelings, no matter how hard I try. The game is not worth the candle.

Copy link
Collaborator

@5abeel 5abeel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nupuruttarwar nupuruttarwar merged commit 1327792 into main Apr 9, 2024
5 checks passed
@nupuruttarwar nupuruttarwar deleted the update_lnw_v3 branch April 9, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants